Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-0.8 audit #1692

Closed
33 tasks done
Tracked by #671
joshlf opened this issue Sep 19, 2024 · 0 comments
Closed
33 tasks done
Tracked by #671

Pre-0.8 audit #1692

joshlf opened this issue Sep 19, 2024 · 0 comments
Labels
blocking-next-release This issue should be resolved before we release on crates.io

Comments

@joshlf
Copy link
Member

joshlf commented Sep 19, 2024 •
edited
Loading

@joshlf joshlf added the blocking-next-release This issue should be resolved before we release on crates.io label Sep 19, 2024
@joshlf joshlf mentioned this issue Sep 19, 2024
Open
87 tasks
jswrenn added a commit that referenced this issue Sep 20, 2024
@jswrenn
[doc] Document Ref PMEs
ba7bb5f 
Makes progress towards #1692
@jswrenn jswrenn mentioned this issue Sep 20, 2024
Merged
jswrenn added a commit that referenced this issue Sep 20, 2024
@jswrenn
Seal ByteOrder trait
edd7a00 
This will allow us to add additional supertraits without breaking
users.

Makes progress towards #1692
@jswrenn jswrenn mentioned this issue Sep 20, 2024
Merged
jswrenn added a commit that referenced this issue Sep 20, 2024
@jswrenn
[doc] Fix broken links in ByteSlice
d69aab9 
Makes progress towards #1692
@jswrenn jswrenn mentioned this issue Sep 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@jswrenn
[doc] Document Ref PMEs (#1697)
0b6a5b1 
Makes progress towards #1692
joshlf added a commit that referenced this issue Sep 20, 2024
@joshlf
[byte_slice] Clean up docs and methods
794fef7 
Makes progress on #1692
@joshlf joshlf mentioned this issue Sep 20, 2024
Merged
joshlf added a commit that referenced this issue Sep 20, 2024
@joshlf
[byte_slice] Clean up docs and methods
26fe155 
Makes progress on #1692
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@jswrenn
[doc] Fix broken links in ByteSlice (#1699)
ee9fa42 
Makes progress towards #1692
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@jswrenn
Seal ByteOrder trait (#1698)
1c49f0c 
This will allow us to add additional supertraits without breaking
users.

Makes progress towards #1692
joshlf added a commit that referenced this issue Sep 20, 2024
@joshlf
[Unalign] Update docs
43eda5f 
Makes progress on #1692
@joshlf joshlf mentioned this issue Sep 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@joshlf
[byte_slice] Clean up docs and methods (#1700)
4ee00b5 
Makes progress on #1692
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@joshlf
[Unalign] Update docs (#1701)
15fa71b 
Makes progress on #1692
jswrenn added a commit that referenced this issue Sep 20, 2024
@jswrenn
Implement TryReadFrom::map_src
633978c 
Make progress towards #1692
@jswrenn jswrenn mentioned this issue Sep 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@jswrenn
Implement TryReadFrom::map_src (#1704)
42ce158 
Make progress towards #1692
joshlf added a commit that referenced this issue Sep 20, 2024
@joshlf
[Ref] Clean up docs
ad8c3f7 
Makes progress on #1692
@joshlf joshlf mentioned this issue Sep 20, 2024
Merged
joshlf added a commit that referenced this issue Sep 20, 2024
@joshlf
[byteorder] Clean up docs
9b4e5be 
Makes progress on #1692
@joshlf joshlf mentioned this issue Sep 20, 2024
Merged
joshlf added a commit that referenced this issue Sep 20, 2024
@joshlf
[byteorder] Clean up docs
a50e594 
Makes progress on #1692
joshlf added a commit that referenced this issue Sep 20, 2024
@joshlf
[Ref] Clean up docs
4e953a8 
Makes progress on #1692
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@joshlf
[byteorder] Clean up docs (#1707)
ba8bf1c 
Makes progress on #1692
github-merge-queue bot pushed a commit that referenced this issue Sep 20, 2024
@joshlf
[Ref] Clean up docs (#1706)
fcb0b32 
Makes progress on #1692
jswrenn added a commit that referenced this issue Sep 21, 2024
@jswrenn
Fix FromBytes::read_from_suffix return type; remove panic paths
2d5304d 
`FromBytes::read_from_suffix` should return a `SizeError`, like
`read_from_bytes` and `read_from_prefix`. This commit corrects this
error, and also removes unreachable panic paths in all three
functions.

Makes progress towards #1692
@jswrenn jswrenn mentioned this issue Sep 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 21, 2024
@jswrenn
Fix FromBytes::read_from_suffix return type; remove panic paths (#1716
c57e3b9 
)

`FromBytes::read_from_suffix` should return a `SizeError`, like
`read_from_bytes` and `read_from_prefix`. This commit corrects this
error, and also removes unreachable panic paths in all three
functions.

Makes progress towards #1692
@joshlf joshlf closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocking-next-release This issue should be resolved before we release on crates.io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshlf