Allow dereferencing an Unalign, add trait impls #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djkoloski can you take a look at this when you get a chance? Please be brutal about the safety comments. I want to make sure they're 100% bulletproof. |
joshlf
force-pushed
the
deref-unalign
branch
3 times, most recently
from
ca666e7 to
e60bf7f
Compare
djkoloski
previously approved these changes
Nov 9, 2022
Provide methods and trait implementations to generate `&T` and `&mut T` from `&Unalign<T>` and `&mut Unalign<T>` respectively. If `T: Unaligned`, then these are infallible. Otherwise, a runtime check must be performed to ensure that the `Unalign<T>` satisfies `T`'s alignment requirement. Since dereferencing is now supported, we can also implement various traits using `Deref` and `DerefMut` impls.
joshlf
force-pushed
the
deref-unalign
branch
from
e60bf7f to
af407d4
Compare
|
Thanks for the review! |
joshlf
added a commit
that referenced
this pull request
Aug 3, 2023
Provide methods and trait implementations to generate `&T` and `&mut T` from `&Unalign<T>` and `&mut Unalign<T>` respectively. If `T: Unaligned`, then these are infallible. Otherwise, a runtime check must be performed to ensure that the `Unalign<T>` satisfies `T`'s alignment requirement. Since dereferencing is now supported, we can also implement various traits using `Deref` and `DerefMut` impls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide methods and trait implementations to generate
&Tand&mut Tfrom&Unalign<T>and&mut Unalign<T>respectively. IfT: Unaligned, then these are infallible. Otherwise, a runtime check must be performed to ensure that theUnalign<T>satisfiesT's alignment requirement.Since dereferencing is now supported, we can also implement various traits using
DerefandDerefMutimpls.