Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Clarify derive dependency recommendation #1672

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Sep 17, 2024

Clarify advice for how to speed up compile times by importing zerocopy and zerocopy-derive separately. The updated advice avoids the risk of duplicate import errors if one of a crate's transitive dependencies adds zerocopy's derive feature.

Closes #1587

Clarify advice for how to speed up compile times by importing zerocopy
and zerocopy-derive separately. The updated advice avoids the risk of
duplicate import errors if one of a crate's transitive dependencies adds
zerocopy's `derive` feature.

Closes #1587
@joshlf joshlf requested a review from jswrenn September 17, 2024 15:28
@joshlf joshlf enabled auto-merge September 17, 2024 15:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (dcf90f3) to head (cb384d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1672   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files          16       16           
  Lines        5805     5805           
=======================================
  Hits         5109     5109           
  Misses        696      696           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 6e78c01 Sep 17, 2024
80 checks passed
@joshlf joshlf deleted the derive-import-docs branch September 17, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The derive feature can cause duplicate import errors
3 participants