Remove deprecated FromBytes::(mut_)slice_from items
#1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
approved these changes
Oct 16, 2024
jswrenn
force-pushed
the
remove-deprecated-frombytes
branch
from
099bc04 to
29b54a1
Compare
These are causing PMEs in the presence of `-C link-dead-code`, which casues them to be monomorphized for `Self = ()`, thus producing the problematic ZSTy DST `[()]`. Also bumps version to 0.8.6. Ref rust-lang/rust#131793 Fixes #1867
jswrenn
force-pushed
the
remove-deprecated-frombytes
branch
from
29b54a1 to
d501481
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.8.x #1923 +/- ##
==========================================
+ Coverage 87.41% 87.59% +0.17%
==========================================
Files 16 16
Lines 6000 5988 -12
==========================================
Hits 5245 5245
+ Misses 755 743 -12 ☔ View full report in Codecov by Sentry. |
|
Force-merged to work around obi1kenobi/cargo-semver-checks#971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are causing PMEs in the presence of
-C link-dead-code, which casues them to be monomorphized forSelf = (), thus producing the problematic ZSTy DST[()].Ref rust-lang/rust#131793
Fixes #1867