Add FromBytes::read_from_io and IntoBytes::write_to_io
#2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
requested changes
Nov 4, 2024
src/lib.rs
Outdated
| @@ -4525,6 +4529,24 @@ pub unsafe trait FromBytes: FromZeros { | |||
| } | |||
| } | |||
|
|
|||
| /// TODO | |||
src/lib.rs
Outdated
| @@ -5188,6 +5210,16 @@ pub unsafe trait IntoBytes { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// TODO | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.8.x #2016 +/- ##
==========================================
+ Coverage 87.59% 87.64% +0.05%
==========================================
Files 16 16
Lines 5988 6016 +28
==========================================
+ Hits 5245 5273 +28
Misses 743 743 ☔ View full report in Codecov by Sentry. |
jswrenn
force-pushed
the
io
branch
2 times, most recently
from
e4949fb to
6367580
Compare
joshlf
requested changes
Nov 5, 2024
Makes progress on #158. Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
joshlf
approved these changes
Nov 8, 2024
joshlf
added a commit
that referenced
this pull request
Nov 11, 2024
Makes progress on #158. Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com> gherrit-pr-id: I9253d6be7407d8d8679ee355e4e71cd9b15b9ff7
|
Backporting in #2046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #158.