Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo_token parameter #263

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Fix repo_token parameter #263

merged 2 commits into from
Aug 15, 2023

Conversation

joycebrum
Copy link
Contributor

@joycebrum joycebrum commented Aug 15, 2023

Hi @joshlf,

I'm suggesting a fix to the scorecard action because the current naming of repo-token is not being recognized.
image

I've changed it to the suggested one: repo_token. That's probably why Branch-Protection is yet as "?"

Additionally I've cleaned some "not related" comments.

Relates to #230

Signed-off-by: Joyce <joycebrum@google.com>
Signed-off-by: Joyce <joycebrum@google.com>
@joshlf joshlf merged commit 2a406e8 into google:main Aug 15, 2023
@joshlf
Copy link
Member

joshlf commented Aug 15, 2023

Thanks, @joycebrum!

joshlf pushed a commit that referenced this pull request Aug 19, 2023
* Fix repo_token mention
* remove comment about private repos

Signed-off-by: Joyce <joycebrum@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants