Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll stable and nightly toolchains separately #446

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 3, 2023

This should allow the stable toolchain to roll successfully sooner after it's released. Previously, both toolchains were rolled together, which meant that when the nightly roll failed (frequent thanks to most nightlies missing at least one target architecture we use in CI), the stable roll would fail too.

@joshlf
Copy link
Member Author

joshlf commented Oct 3, 2023

Tested this by first pushing a version that is triggered on pull requests. That run generated these PRs for stable and nightly.

This should allow the stable toolchain to roll successfully sooner after
it's released. Previously, both toolchains were rolled together, which
meant that when the nightly roll failed (frequent thanks to most
nightlies missing at least one target architecture we use in CI), the
stable roll would fail too.
@joshlf joshlf force-pushed the roll-stable-nightly-separately branch from 920a2e6 to 5e16d4f Compare October 3, 2023 04:22
@joshlf joshlf requested a review from jswrenn October 3, 2023 04:22
@jswrenn jswrenn added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 8656094 Oct 3, 2023
152 checks passed
@jswrenn jswrenn deleted the roll-stable-nightly-separately branch October 3, 2023 12:15
samuelselleck pushed a commit to samuelselleck/zerocopy that referenced this pull request Oct 13, 2023
This should allow the stable toolchain to roll successfully sooner after
it's released. Previously, both toolchains were rolled together, which
meant that when the nightly roll failed (frequent thanks to most
nightlies missing at least one target architecture we use in CI), the
stable roll would fail too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants