Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][kani] Pass correct RUSTFLAGS #493

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[ci][kani] Pass correct RUSTFLAGS #493

merged 1 commit into from
Oct 12, 2023

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 11, 2023

Previously, we spuriously didn't pass our global RUSTFLAGS that are passed in other CI jobs. As a result, -Dwarnings is now used, which causes byteorder::tests::test_ops_impls to be recognized as unused. This is also fixed.

@joshlf joshlf requested a review from jswrenn October 11, 2023 23:54
Previously, we spuriously didn't pass our global `RUSTFLAGS` that are
passed in other CI jobs. As a result, `-Dwarnings` is now used, which
causes `byteorder::tests::test_ops_impls` to be recognized as unused.
This is also fixed.
@joshlf joshlf added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 10eb7f9 Oct 12, 2023
144 checks passed
@joshlf joshlf deleted the kani-unused branch October 12, 2023 00:07
samuelselleck pushed a commit to samuelselleck/zerocopy that referenced this pull request Oct 13, 2023
Previously, we spuriously didn't pass our global `RUSTFLAGS` that are
passed in other CI jobs. As a result, `-Dwarnings` is now used, which
causes `byteorder::tests::test_ops_impls` to be recognized as unused.
This is also fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants