Add transmute_mut! macro
#550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
force-pushed
the
transmute_mut
branch
from
6d357d9
to
dccd6f5
Compare
joshlf
requested changes
Oct 26, 2023
jswrenn
force-pushed
the
transmute_mut
branch
2 times, most recently
from
0662549
to
a6e0d10
Compare
joshlf
requested changes
Oct 27, 2023
src/lib.rs
Outdated
Comment on lines
2023
to
2027
| let u; | ||
|
|
||
| $crate::assert_size_eq!(t, u); | ||
|
|
||
| &u |
There was a problem hiding this comment.
Slight stylistic preference for grouping these together, but feel free to ignore this.
Same in the next branch.
Suggested change
| let u; | |
| $crate::assert_size_eq!(t, u); | |
| &u | |
| let u; | |
| $crate::assert_size_eq!(t, u); | |
| &u |
src/lib.rs
Outdated
Comment on lines
2121
to
2111
| // Reborrow so that mutable references are supported too. | ||
| // | ||
| // In the rest of the comments, we refer only to `&T` since this | ||
| // reborrow ensures that `e` is an immutable reference. | ||
| let e = &mut *$e; |
There was a problem hiding this comment.
Is this necessary for transmute_mut!?
src/lib.rs
Outdated
| { | ||
| loop {} | ||
| } | ||
| transmute(&mut *e) |
There was a problem hiding this comment.
Can this not just be transmute(e)?
src/lib.rs
Outdated
Comment on lines
2152
to
2156
| let u; | ||
|
|
||
| $crate::assert_size_eq!(t, u); | ||
|
|
||
| &mut u |
There was a problem hiding this comment.
Same here, also optional.
Suggested change
| let u; | |
| $crate::assert_size_eq!(t, u); | |
| &mut u | |
| let u; | |
| $crate::assert_size_eq!(t, u); | |
| &mut u |
src/lib.rs
Outdated
Comment on lines
2168
to
2140
| let mut u = unreachable!(); | ||
|
|
||
| $crate::assert_align_gt_eq!(t, u); | ||
|
|
||
| &mut u |
There was a problem hiding this comment.
Same here, also optional.
Suggested change
| let mut u = unreachable!(); | |
| $crate::assert_align_gt_eq!(t, u); | |
| &mut u | |
| let mut u = unreachable!(); | |
| $crate::assert_align_gt_eq!(t, u); | |
| &mut u |
jswrenn
force-pushed
the
transmute_mut
branch
3 times, most recently
from
4661929
to
9a6ec7a
Compare
joshlf
previously approved these changes
Oct 27, 2023
jswrenn
force-pushed
the
transmute_mut
branch
2 times, most recently
from
0ad7e2b
to
b30dab4
Compare
joshlf
previously approved these changes
Oct 27, 2023
This macro is like the existing `transmute!`, but it transmutes mutable references rather than values. Releasing 0.7.17 Issue #159
jswrenn
force-pushed
the
transmute_mut
branch
from
b30dab4
to
32633ce
Compare
joshlf
approved these changes
Oct 27, 2023
This was referenced Nov 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro is like the existing
transmute!, but it transmutes mutable references rather than values.Issue #159