-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed as_bytes_mut
to as_mut_bytes
#870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just edit your commit message to:
Renamed `as_bytes_mut` to `as_mut_bytes`
efa1e20
to
c39b863
Compare
@jswrenn Renamed commit |
Whoops, sorry for the inconvenience, but I didn't mean for you to edit out the reference to the issue. The full message should be something like this:
|
...and if you want to be really pedantic with our commit message guidelines, it should be "Rename |
c39b863
to
bff9148
Compare
One last tweak: Just put a double newline between the subject and 'Fixes', like this:
Right now, they're all on one line. |
We do this because git treats the first line of the commit message as its subject; see here: https://github.com/google/zerocopy/commit/bff9148ad8e7bf034e0992a1f8b4bf9553f2e386.patch |
bff9148
to
0347a27
Compare
@jswrenn fixed commit message |
Thanks for this, @dorryspears ! |
Closes #253
I saw this in the nice-to-haves in #671, so I thought I would knock it out.