Support testing TryFromBytes for !NoCell types #924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our test harness for
TryFromBytes
types assumed that those types also implementedNoCell
. This commit introduces machinery that allows us to conditionally execute certain steps of our tests depending on whether or not the type under test implementsNoCell
.This commit also lifts the
T: NoCell
bound inTryFromBytes for MaybeUninit<T>
in order to test this machinery.