fix: handle endless streams piping (#936)

closes #935
google · Nov 8, 2024 · 3f164e0 · 3f164e0
1 parent 6eb540f
commit 3f164e0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/core.ts b/src/core.ts
@@ -358,8 +358,7 @@ export class ProcessPromise extends Promise<ProcessOutput> {
       from.pipe(dest.stdin)
       return dest
     }
-
-    from.pipe(dest)
+    from.once('end', () => dest.emit('end-piped-from')).pipe(dest)
     return promisifyStream(dest)
   }
 

diff --git a/src/util.ts b/src/util.ts
@@ -462,6 +462,7 @@ export const promisifyStream = <S extends Writable>(
             target
               .once('error', (e) => _rej(rej(e)))
               .once('finish', () => _res(res(target)))
+              .once('end-piped-from', () => _res(res(target)))
           )
       }
       const value = Reflect.get(target, key)

diff --git a/test/core.test.js b/test/core.test.js
@@ -427,6 +427,11 @@ describe('core', () => {
           assert.equal((await fs.readFile(file)).toString(), 'HELLO\n')
           await fs.rm(file)
         })
+
+        test('$ > stdout', async () => {
+          const p = $`echo 1`.pipe(process.stdout)
+          assert.equal(await p, process.stdout)
+        })
       })
 
       it('supports delayed piping', async () => {