Port listening doesn't stop when using CTRL+C

[ziimakc]

Expected Behavior

Running and stopping server with CTRL+C should stop server from listening on port.

Actual Behavior

Running and stopping server with CTRL+C doesn't stop server from listening on port.

Steps to Reproduce the Problem

Running this command node ./server.js manually 2 times works fine, doing the same using zx ./scripts/dev.js fails second time with error about port which server is listening is already in use.

This started to happen after update to v8.

#!/usr/bin/env bash

import { $ } from "zx";

await $({ verbose: true})`node ./server.js`;

Does anything changed and I need somehow manually kill a process?

Specifications

• Version: 8.0.1
• Platform: wsl ubuntu 22.04

[antongolub]

Ouch, we should make detached option configuralble.
https://nodejs.org/api/child_process.html#optionsdetached

[ziimakc]

@antongolub my platform is linux, will it work fine by default or do I need to specify detached=? Zx version 7 works fine

[antongolub]

Well, the only purpose for setting detached=true by default is to make $`sleep 999` abortable.
nodejs/node#37518

@antonmedv, what do you think?

[antonmedv]

I did not get this. We want to make detached=true by default?

[antongolub]

v7 uses false
v8 uses true to handle abort controller's corner case.
@antonmedv, Is this a some kind of sensible defaults? should we rollback the value?

[antonmedv]

Yes, I don't think we should detach process.

to handle abort controller's corner case.

What corner case?

[antongolub]

corner case?

Technically, detached + abort() kills the starter process (bash) only.

[lorisleiva]

Hi there,

I've got the same issue. What do I need to do in v8 to make CTRL+C kill the child process?

[antongolub]

@lorisleiva, @ziimakc

Could you check the fix proposal?

npm i zx@8.0.1-dev.b52bcd9

[lorisleiva]

Works like a charm on my side. Thank you! 🍺

[ziimakc]

@antonmedv same, works fine, thanks!