Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a caching channel factory. #92

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Add a caching channel factory. #92

merged 1 commit into from
Jun 11, 2019

Conversation

AnashOommen
Copy link
Member

No description provided.

@AnashOommen AnashOommen self-assigned this Jun 11, 2019
@BenRKarl
Copy link

Are you going to add unit tests for this class?

sundquist
sundquist approved these changes Jun 11, 2019
View reviewed changes
Copy link

@sundquist sundquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnashOommen
Copy link
Member Author

Are you going to add unit tests for this class?

Filed a bug against myself: #99

@AnashOommen AnashOommen merged commit aecfe67 into master Jun 11, 2019
@AnashOommen AnashOommen deleted the cached-factory branch December 3, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryLiseno CoryLiseno CoryLiseno approved these changes

@sundquist sundquist sundquist approved these changes

Assignees

@AnashOommen AnashOommen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnashOommen @BenRKarl @CoryLiseno @sundquist