Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing in service account string capability #871

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

srijan-chaudhuri
Copy link

@srijan-chaudhuri srijan-chaudhuri commented Jun 17, 2024

Description:

This PR adds the ability to provide credentials via an environment variable for use cases where adding a .json to the filesystem in the runtime environment is not feasible for security reasons.

Testing:

Called get_credentials in oauth2.py by declaring a "json_key_string" (item) with personal credentials in config_data (dictionary)

The result was that we received as a valid credentials object.

References:

Would highly recommend seeing this as similar approach has been executed in big query api library!

BQ: https://github.com/anelendata/tap-bigquery/blob/master/tap_bigquery/sync_bigquery.py
Implementation: https://gitlab.1password.io/data/data-issues/-/issues/3347#note_3160542

Copy link

google-cla bot commented Jun 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@srijan-chaudhuri
Copy link
Author

srijan-chaudhuri commented Jul 8, 2024

@dmosorast, @dsprayberry, @Vi6hal, @bryantgray would love your take on this PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant