Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MobileAds.init from a Background thread #1179

Merged
merged 4 commits into from
Oct 3, 2024
Merged

MobileAds.init from a Background thread #1179

merged 4 commits into from
Oct 3, 2024

Conversation

LTPhantom
Copy link
Collaborator

Description

Calling MobileAds init from background thread.

Related Issues

#1135

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@malandr2
Copy link
Collaborator

@LTPhantom
Copy link
Collaborator Author

LTPhantom commented Oct 3, 2024

Appears the AppLovin APIs have changed - they are causing a failure: https://github.com/googleads/googleads-mobile-flutter/blob/main/samples/admob/mediation_example/ios/Runner/AppDelegate.m#L46

There is a major change on latest AppLovin which is affecting the sample. For now I limited the version used by it, but we might need to rethink the sample in the future.

@LTPhantom LTPhantom marked this pull request as ready for review October 3, 2024 04:56
@LTPhantom LTPhantom merged commit b63c671 into main Oct 3, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants