Set plugin #916
Merged
Set plugin #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add plist and pbxproj to gitignore
This reverts commit e9715c9.
…ersion. * Update `RequestConfiguration` with test device ID.
…ersion. * Update `RequestConfiguration` with test device ID.
LTPhantom
approved these changes
Sep 8, 2023
| Method method = clazz.getDeclaredMethod("setPlugin", String.class); | ||
| method.setAccessible(true); | ||
| method.invoke(null, Constants.REQUEST_AGENT_PREFIX_VERSIONED); | ||
| } catch (Exception ignored) { |
There was a problem hiding this comment.
Is there a special reason why this is ignored?
There was a problem hiding this comment.
This will happen if the reflection fails. For example, if the publisher has set their version of GMA to an older version that doesn't have the API. I don't think it's worth logging an error here since we're not invoking a public api
jjliu15
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RequestConfigurationwith test device ID.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?