Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony5 support #637

Closed
weberdominik opened this issue Jan 9, 2020 · 3 comments
Closed

Symfony5 support #637

weberdominik opened this issue Jan 9, 2020 · 3 comments

Comments

@weberdominik
Copy link

We are currently unable to upgrade our project because googleadsphplib does not yet support Symfony5. Is an update planned or is there another way to upgrade?
@fiboknacky
Copy link
Member

There is a pull request opened, but the unit test fails for Symfony 5.
The pull request author has not got back to me yet, and I don't have time to investigate further too.
So, currently I have no ETA but will look into this asap.

@mrpavlikov mrpavlikov mentioned this issue Jan 16, 2020
Closed
fiboknacky added a commit that referenced this issue Jan 17, 2020
@fiboknacky
Merge pull request #638 from mrpavlikov/feature/symfony-5-support
656e27b 
#637 symfony 5 support added
@mrpavlikov
Copy link

mrpavlikov commented Jan 17, 2020 •
edited
Loading

@weberdominik

$ composer require googleads/googleads-php-lib "dev-master"

works fine atm

@fiboknacky
Copy link
Member

#638 has been merged, so this is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fiboknacky @mrpavlikov @weberdominik