Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 236 #251

Merged
merged 2 commits into from
Mar 8, 2017
Merged

Fix issue 236 #251

merged 2 commits into from
Mar 8, 2017

Conversation

jclee100
Copy link
Contributor

@jclee100 jclee100 commented Mar 7, 2017

Resubmit with tests

FYI, executing phpunit gave me 2 failures.

1) Google\AdsApi\Common\SoapLogMessageFormatterTest::testFormatDetailed
Failed asserting that two strings are identical.
...
\googleads-php-lib\tests\Google\AdsApi\Common\SoapLogMessageFormatterTest.php:128

2) Google\AdsApi\Common\SoapLogMessageFormatterTest::testFormatDetailedWithScrubbing
Failed asserting that two strings are identical.
...
\googleads-php-lib\tests\Google\AdsApi\Common\SoapLogMessageFormatterTest.php:147

Maybe it's ok since it looks like a Windows thing:
#Warning: Strings contain different line endings!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@fiboknacky
Copy link
Member

You've signed CLA already right?

@jclee100
Copy link
Contributor Author

jclee100 commented Mar 7, 2017

Just did.

@googlebot
Copy link

CLAs look good, thanks!

@fiboknacky fiboknacky self-assigned this Mar 7, 2017
@fiboknacky fiboknacky self-requested a review March 7, 2017 17:42
$campaign->setId(9223372036854775900);
$campaign->setName('Test large ID');
$operand = new FakeOperand();
$operand->setCampaign($campaign);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a new line after this line please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will figure out how I can edit the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I can do that when I sync this with our codebase.
Thanks for your contribution!

@fiboknacky fiboknacky merged commit e946ffc into googleads:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants