-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 236 #251
Fix issue 236 #251
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
You've signed CLA already right? |
Just did. |
CLAs look good, thanks! |
$campaign->setId(9223372036854775900); | ||
$campaign->setName('Test large ID'); | ||
$operand = new FakeOperand(); | ||
$operand->setCampaign($campaign); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put a new line after this line please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will figure out how I can edit the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. I can do that when I sync this with our codebase.
Thanks for your contribution!
Resubmit with tests
FYI, executing phpunit gave me 2 failures.
Maybe it's ok since it looks like a Windows thing:
#Warning: Strings contain different line endings!