-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable simulated throttling by default. #120
Conversation
This is a temporary change until simulated results can be verified as accurate.
FYI not sure if you've already read through the LH variability and accuracy analysis doc, but it should hopefully be a good starting point for your verification process :) The tl;dr is...
I'm not sure what use case this script falls into but large scale repeated runs for "true" accuracy should definitely strive to use packet-level throttling. Moving from simulated throttling to no throttling though would definitely be a step backwards in terms of mobile performance accuracy. |
@patrickhulce I think I've briefly read it before, but I should definitely read it closer to better understand everything here. The real issue we've been running into here is the simulation of network timing, this is primarily in preparation for #121 which switches our first paint audit to use a network ping rather than the Long term, we are planning to reenable simulation, but we need to spend more time ensuring that our results make sense before doing that. |
Ah, gotcha thanks for the context! :)
Interesting, we're probably missing whatever is needed to connect the dots then. Is it just an ordinary request made within the frame? Image request? XHR?
50% earlier than the observed time of the request and the ad was loaded 40s in? I'm not sure I follow this bit sorry :( FWIW, this is stretching a bit the original intention of simulation since until this point we haven't been too concerned about the ordering of specific resources so long as all the dependencies are captured and the final end time is the same. You might end up running into more of these types of situations when focusing on start times of specific resources, but we can come up with some changes to make this part more accurate if needed. |
This is a temporary change until simulated results can be verified as accurate.