-
Notifications
You must be signed in to change notification settings - Fork 38
Rename longrunning.operations* modules. #159
Rename longrunning.operations* modules. #159
Conversation
This commit renames the `operations_grpc` and `operations_proto` modules to `operations_grpc_pb2` and `operations_proto_pb2`. This resolves a breaking change in the `protobuf==3.2.0` Python package which requires some objects only to be created in modules that end in `_pb2`.
Do any downstream users import |
All downstream users that I know of import Ironically, I could solve the problem for both cases by just having |
Cool, thanks. |
FWIW gRPC codegen now automatically generates a |
I have proven locally that 572db4b fixes googleapis/google-cloud-python#2989. @geigerj @jonparrott Any issues with what I did there? If not, I will merge and then push 1.5.2 to PyPI (and then a re-test on Travis will fix Jon's PR). |
This commit renames the
operations_grpc
andoperations_proto
modules tooperations_grpc_pb2
andoperations_proto_pb2
. This restores compatibility lost due to a change in theprotobuf==3.2.0
Python package which requires some objects only to be created in modules that end in_pb2
.Notes: