Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add some helpers #1017

Merged
merged 4 commits into from
Oct 5, 2022
Merged

chore: add some helpers #1017

merged 4 commits into from
Oct 5, 2022

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Sep 14, 2022 •
edited
Loading

This adds a few helpers that will be useful in implementing #972. I started on that issue, and while I didn't get far, I figured these would be useful. @acamadeo will be taking on that issue now, so I want them to have the helpers.

@noahdietz noahdietz requested a review from a team as a code owner September 14, 2022 17:19
GregFurmanek
GregFurmanek reviewed Oct 4, 2022
View reviewed changes
rules/internal/utils/http_test.go Show resolved Hide resolved
rules/internal/utils/http.go Outdated Show resolved Hide resolved
rules/internal/utils/find_test.go Outdated Show resolved Hide resolved
rules/internal/utils/find.go Outdated Show resolved Hide resolved
rules/internal/utils/find.go Outdated Show resolved Hide resolved
rules/internal/utils/extension.go Outdated Show resolved Hide resolved
rules/internal/utils/extension_test.go Outdated Show resolved Hide resolved
rules/internal/utils/extension_test.go Show resolved Hide resolved
GregFurmanek
GregFurmanek reviewed Oct 5, 2022
View reviewed changes
rules/internal/utils/http_test.go Outdated Show resolved Hide resolved
rules/internal/utils/find_test.go Outdated Show resolved Hide resolved
@noahdietz noahdietz added the automerge Summon MOG for automerging label Oct 5, 2022
GregFurmanek
GregFurmanek approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@GregFurmanek GregFurmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gcf-merge-on-green gcf-merge-on-green bot merged commit a800f77 into googleapis:main Oct 5, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Oct 5, 2022
@noahdietz noahdietz deleted the more-helpers branch October 6, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregFurmanek GregFurmanek GregFurmanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @GregFurmanek