Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AIP-148): use uid instead of id #1135

Merged
merged 4 commits into from
Apr 28, 2023
Merged

feat(AIP-148): use uid instead of id #1135

merged 4 commits into from
Apr 28, 2023

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Apr 13, 2023 •
edited
Loading

The standard field for the Resource ID segment within a resource is uid, not id per AIP-148. So let's enforce that.

Fixes #1068

@noahdietz noahdietz requested a review from a team as a code owner April 13, 2023 15:17
toumorokoshi
toumorokoshi suggested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the example and docs need to be updated, but the code LGTM.

docs/rules/0148/use-uid.md Outdated Show resolved Hide resolved
docs/rules/0148/use-uid.md Outdated Show resolved Hide resolved
docs/rules/0148/use-uid.md Outdated Show resolved Hide resolved
rules/aip0148/use_uid_test.go Show resolved Hide resolved
shwoodard
shwoodard reviewed Apr 27, 2023
View reviewed changes
rules/aip0148/use_uid.go Outdated Show resolved Hide resolved
toumorokoshi
toumorokoshi approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@noahdietz noahdietz merged commit f5c84bb into googleapis:main Apr 28, 2023
@noahdietz noahdietz deleted the no-self-link branch April 28, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@shwoodard shwoodard shwoodard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-148: Recommend uid instead of id
3 participants
@noahdietz @shwoodard @toumorokoshi