Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aip-136): response message name #1387

Merged
merged 10 commits into from
May 17, 2024
Merged

feat(aip-136): response message name #1387

merged 10 commits into from
May 17, 2024

Conversation

liveFreeOrCode
Copy link
Contributor

AIP-136

  • Custom methods should return a response message matching the RPC name, with a Response suffix.
    • When operating on a specific resource, a custom method may return the resource itself

@liveFreeOrCode
feat(aip-0136): response message name
62a90e5 
This patch implements the guidelines around the response message
name for custom methods

Ref: https://google.aip.dev/136
@liveFreeOrCode liveFreeOrCode requested a review from a team as a code owner May 15, 2024 15:10
@liveFreeOrCode liveFreeOrCode changed the title feat(aip-0136): response message name feat(aip-136): response message name May 15, 2024
noahdietz
noahdietz reviewed May 17, 2024
View reviewed changes
rules/aip0136/response_message_name.go Outdated Show resolved Hide resolved
rules/aip0136/response_message_name.go Outdated Show resolved Hide resolved
rules/aip0136/response_message_name.go Outdated Show resolved Hide resolved
rules/aip0136/response_message_name.go Outdated Show resolved Hide resolved
docs/rules/0136/response-message-name.md Outdated Show resolved Hide resolved
docs/rules/0136/response-message-name.md Outdated Show resolved Hide resolved
noahdietz
noahdietz approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done, thank you @liveFreeOrCode

rules/aip0136/response_message_name_test.go Outdated Show resolved Hide resolved
@noahdietz noahdietz merged commit 9e43e3f into googleapis:main May 17, 2024
6 checks passed
@release-please release-please bot mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liveFreeOrCode @noahdietz