Allow multiple --proto_path #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
pcj
force-pushed
the
proto_paths
branch
2 times, most recently
from
a07a9e3
to
c12a7a7
Compare
|
I am not sure if package |
|
The I've always used multiple -I (--proto_path) flags to |
robcapo
reviewed
Jun 24, 2019
| Name: "proto_path", | ||
| Value: ".", | ||
| Usage: "the directory in which for protoc to search for imports", | ||
| Value: &cli.StringSlice{"."}, |
There was a problem hiding this comment.
What's the behavior of this value? If the user specifies value(s) will they override this slice or append to it?
There was a problem hiding this comment.
Since 2016, it overrides: urfave/cli#160
lukesneeringer
approved these changes
Aug 23, 2019
rambleraptor
added a commit
to rambleraptor/api-linter
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the CLI arguments to allow multiple
--proto_pathflags that are propagated to the protocol compiler.