fix: distinguish idle from program time #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 90.05% 90.12% +0.07%
==========================================
Files 6 6
Lines 392 395 +3
Branches 68 68
==========================================
+ Hits 353 356 +3
Misses 39 39
Continue to review full report at Codecov.
|
aalexand
reviewed
Jul 9, 2018
| // undocumented API. | ||
| // See https://github.com/nodejs/node/issues/19009#issuecomment-403161559. | ||
| // tslint:disable-next-line no-any | ||
| (process as any)._startProfilerIdleNotifier(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@ofrobots The CI fails on node 6? |
|
I've relaunched the job. The error message didn't seem related. /cc @nolanmar511 in case you have an idea of what is going on. |
|
@ofrobots Can this be merged? |
|
There is no LGTM, but this is good to go from my side :). |
aalexand
approved these changes
Jul 17, 2018
|
@ofrobots Ah, I thought I LGTM'ed it. Done now. Please merge once CI has finished. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38