Save profiles when running startLocal #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
nolanmar511
force-pushed
the
start-local
branch
from
0bcd957 to
47b7daf
Compare
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 95.77% 93.16% -2.61%
==========================================
Files 6 6
Lines 355 366 +11
Branches 58 60 +2
==========================================
+ Hits 340 341 +1
- Misses 15 25 +10
Continue to review full report at Codecov.
|
nolanmar511
force-pushed
the
start-local
branch
4 times, most recently
from
a54f748 to
e15ec65
Compare
nolanmar511
force-pushed
the
start-local
branch
from
e15ec65 to
b9489ed
Compare
|
PTAL |
aalexand
reviewed
Jan 10, 2018
| @@ -148,13 +151,27 @@ export async function startLocal(config: Config = {}): Promise<void> { | |||
| if (!config.disableHeap) { | |||
| const heap = await profiler.profile( | |||
| {name: 'HEAP-Profile' + new Date(), profileType: 'HEAP'}); | |||
| const decodedBytes = Buffer.from(heap.profileBytes as 'string', 'base64'); | |||
| fs.writeFile( | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Should this PR be closed or submitted? |
|
I think I'll close this. If startLocal does save profiles, it should probably be only when the user specifies this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, profiles are thrown away when running startLocal. With this change, profiles will be written out to files.