Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename TraceAgent/TraceApi to Tracer #815

Merged
merged 2 commits into from
Jul 19, 2018
Merged

feat: rename TraceAgent/TraceApi to Tracer #815

merged 2 commits into from
Jul 19, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jul 18, 2018 •
edited
Loading

BREAKING CHANGE: TraceAgent has been renamed to Tracer. In plugins, Patch has been renamed Monkeypatch, and Patch is now Monkeypatch|Intercept (this is a rename of Instrumentation). There are no user-visible JS changes.

TraceAgent is a misnomer since the module as a whole is the "agent", not the object that is returned when the Trace Agent is started. (This is already reflected in the docs, where it has been called TraceApi). This change makes things consistent so it is called Tracer everywhere.

The one implementation of TraceAgent (which was also called TraceAgent) is now StackdriverTracer. This object is never constructed by the user, so this is a no-op change for JS users.

A couple of unused imports have also been removed.

@kjin kjin requested a review from a team July 18, 2018 22:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 18, 2018
ofrobots
ofrobots approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you modify the commit message to make it clearly in the the first sentence that the breaking change only is limited to the exported types and no JS-exposed names and/or functionality is changing.

@kjin kjin merged commit dde86d3 into googleapis:master Jul 19, 2018
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjin @ofrobots @googlebot