Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapic: move versionGo helper into gax-go #1299

Closed
noahdietz opened this issue Apr 17, 2023 · 0 comments · Fixed by #1359
Closed

gapic: move versionGo helper into gax-go #1299

noahdietz opened this issue Apr 17, 2023 · 0 comments · Fixed by #1359
Assignees
@noahdietz
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Go GAPIC Moderniz...

Comments

@noahdietz
Copy link
Collaborator

The versionGo helper doesn't need to be generated into every single GAPIC's doc.go file.

Let's consolidate it into gax-go.
@noahdietz noahdietz added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 17, 2023
@noahdietz noahdietz added this to the Go GAPIC house keeping milestone Apr 17, 2023
@noahdietz noahdietz self-assigned this Jun 5, 2023
@noahdietz noahdietz mentioned this issue Jun 5, 2023
Merged
@noahdietz noahdietz mentioned this issue Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
Go GAPIC Modernization
Development

Successfully merging a pull request may close this issue.

fix(gengapic): use gax GoVersion noahdietz/gapic-generator-go
1 participant
@noahdietz