Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gengapic): use gax GoVersion #1359

Merged
merged 2 commits into from
Jun 13, 2023
Merged

fix(gengapic): use gax GoVersion #1359

merged 2 commits into from
Jun 13, 2023

Conversation

noahdietz
Copy link
Collaborator

Replace per-package generated versionGo helper with use of gax.GoVersion in gax/v2 v2.11.0. Update deps accordingly.

Fixes #1299

@noahdietz noahdietz requested review from a team as code owners June 13, 2023 20:28
codyoss
codyoss approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice negative commit! We need to make sure we fully roll-out the gax update before we put this into googleapis

@noahdietz
Copy link
Collaborator Author

We need to make sure we fully roll-out the gax update before we put this into googleapis

Yep, totally.

@noahdietz noahdietz merged commit 9116eca into googleapis:main Jun 13, 2023
@noahdietz noahdietz deleted the go-version branch June 13, 2023 21:31
@release-please release-please bot mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gapic: move versionGo helper into gax-go
2 participants
@noahdietz @codyoss