Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapic: move insertMetadata helper into gax-go #1300

Closed
noahdietz opened this issue Apr 17, 2023 · 1 comment · Fixed by #1368 or #1373
Closed

gapic: move insertMetadata helper into gax-go #1300

noahdietz opened this issue Apr 17, 2023 · 1 comment · Fixed by #1368 or #1373
Assignees
@quartzmo
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Go GAPIC Moderniz...

Comments

@noahdietz
Copy link
Collaborator

The insertMetadata helper doesn't need to be generated into every single GAPIC's doc.go file.
@noahdietz noahdietz added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 17, 2023
@noahdietz noahdietz added this to the Go GAPIC house keeping milestone Apr 17, 2023
@noahdietz noahdietz mentioned this issue Apr 17, 2023
Closed
@noahdietz
Copy link
Collaborator Author

Here are the docs for gRPC Metadata (aka headers): https://github.com/grpc/grpc-go/blob/master/Documentation/grpc-metadata.md

@quartzmo quartzmo self-assigned this Jun 9, 2023
quartzmo added a commit to quartzmo/gax-go that referenced this issue Jun 9, 2023
@quartzmo
feat(v2): add InsertMetadata to header
1056695 
refs: googleapis/gapic-generator-go#1300
@quartzmo quartzmo mentioned this issue Jun 9, 2023
Closed
quartzmo added a commit to quartzmo/gax-go that referenced this issue Jun 22, 2023
@quartzmo
feat(v2): add InsertMetadata to header
8620d81 
refs: googleapis/gapic-generator-go#1300
@quartzmo quartzmo mentioned this issue Jun 22, 2023
Merged
quartzmo added a commit to googleapis/gax-go that referenced this issue Jun 26, 2023
@quartzmo
feat(v2): add BuildHeaders and InsertMetadataIntoOutgoingContext to h…
6a4b89f 
…eader (#290)

refs: googleapis/gapic-generator-go#1300
refs: googleapis/gapic-generator-go#1301
quartzmo added a commit to quartzmo/gapic-generator-go that referenced this issue Jul 7, 2023
@quartzmo
feat(gengapic): use gax.InsertMetadataIntoOutgoingContext
a595487 
closes: googleapis#1300
@quartzmo quartzmo mentioned this issue Jul 7, 2023
Merged
quartzmo added a commit to quartzmo/gapic-generator-go that referenced this issue Jul 7, 2023
@quartzmo
feat(gengapic): use gax.InsertMetadataIntoOutgoingContext
e5d20e7 
closes: googleapis#1300
quartzmo added a commit that referenced this issue Jul 12, 2023
@quartzmo
feat(gengapic): use gax.BuildHeaders and gax.InsertMetadataIntoOutgoi…
6f782f9 
…ngContext (#1368)

closes: #1300
closes: #1301
@release-please release-please bot mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
Go GAPIC Modernization
2 participants
@quartzmo @noahdietz