feat(gengapic): generate helpers for Go 1.23 iterators #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes starts generating build tag protected adapters for using our iterator types in Go range expressions. Related: googleapis/gax-go#358
codyoss
added
the
do not merge
|
requires gax changes to be fully released and rolled out to clients |
codyoss
removed
the
do not merge
|
The new gax libraries have been rolled out to all clients. This is now safe for review. |
noahdietz
approved these changes
Jul 24, 2024
|
Agreed. Let's wait until 1.23 is out, which should be in about 2-3 weeks. |
codyoss
added
the
do not merge
codyoss
removed
the
do not merge
quartzmo
reviewed
Aug 15, 2024
quartzmo
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes starts generating build tag protected adapters for using our iterator types in Go range expressions.
Related: googleapis/gax-go#358