feat: add logging to gapics #1572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a follow up to this PR we will need to add a little logging support in the gax REST streaming helper. For now we should add this with minimal changes but in the future we may want to feed that helper more information to have richer logs. This is a very small amount of RPCs that use this code path today.
codyoss
added
the
do not merge
|
Requires googleapis/gax-go#372 and rollout to all clients and showcase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to this PR we will need to add a little logging support in the gax REST streaming helper. For now we should add this with minimal changes but in the future we may want to feed that helper more information to have richer logs. This is a very small amount of RPCs that use this code path today.