fix: Get numeric value for Enum fields if it is configured as query param or path param #1042

blakeli0 · 2022-09-22T15:48:27Z

Get numeric value for Enum fields if it is configured as query param or path param. Refactor HttpBinding to include Field info and use builder.
Found an existing issue regarding how query params are populated. Add comments to explain the current behavior and expected behavior for populating query params. Created issue #1041 to track the future work.

…aram or path param. Refactor HttpBinding to use builder.

alicejli

Some small nits and a general question on the compliance.proto. Otherwise it looks good; thank you for the thorough comments and your hard work on this feature!

src/main/java/com/google/api/generator/gapic/model/HttpBindings.java

src/test/java/com/google/api/generator/gapic/model/HttpBindingsTest.java

alicejli · 2022-09-26T19:33:10Z

src/test/proto/compliance.proto

@@ -80,6 +80,44 @@ service Compliance {
      get: "/v1beta1/repeat/{info.f_string=first/*}/{info.f_child.f_string=second/**}:pathtrailingresource"
    };
  }
+
+  // This method requests an enum value from the server. Depending on the contents of EnumRequest, the enum value returned will be a known enum declared in the


general question - is there a reason this proto doesn't match https://github.com/googleapis/gapic-showcase/blob/main/schema/google/showcase/v1beta1/compliance.proto exactly?

This was way before I joined, but I guess what happened was that the showcase protos have a lot of edge cases that we want to use, so instead of creating protos from scratch for our test cases, we just copied over these showcase protos and use them as they are. However, protos in showcase evolve over time and we didn't update them regularly.

sonarqubecloud · 2022-09-27T04:27:09Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

97.2% Coverage
0.0% Duplication

…aram or path param (#1042) Get numeric value for Enum fields if it is configured as query param or path param. Refactor HttpBinding to include Field info and use builder.

…aram or path param (#1042) Get numeric value for Enum fields if it is configured as query param or path param. Refactor HttpBinding to include Field info and use builder.

… query param or path param (#1042)" This reverts commit 4b5eadb.

* Revert "test: update golden files after annotations import fix" This reverts commit 0bbfc59. * Revert "fix(ast): add import generation for annotations on VariableExpr (#1076)" This reverts commit 9e4721f. * Revert "chore(main): release 2.10.3 (#1079)" This reverts commit 63b9bce. * Revert "fix: fixes regionTag breakage (#1068)" This reverts commit cd35be8. * Revert "fix: fix REST transport client creation generated javadoc sample (#1077)" This reverts commit 5346eef. * Revert "refactor: expose parsed api short name and version as fields in Service (#1075)" This reverts commit 2ebe948. * Revert "chore(deps): update dependency org.apache.maven.plugins:maven-shade-plugin to v3.4.1 (#1072)" This reverts commit 6774245. * Revert "chore(main): release 2.10.2 (#1067)" This reverts commit e8ee82f. * Revert "fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 (#1063)" This reverts commit aa1782d. * Revert "fix: update regionTag to use service name (#1047)" This reverts commit 38010fd. * Revert "chore(main): release 2.10.1 (#1036)" This reverts commit 3282e0f. * Revert "deps: Upgrade protobuf to 3.21.7 (#1048)" This reverts commit c768691. * Revert "fix: update sample region tag to parse host instead of proto package (#1040)" This reverts commit eb94f30. * Revert "chore(deps): update dependency com.google.auto.value:auto-value to v1.10 (#1058)" This reverts commit bd5599f. * Revert "fix: Get numeric value for Enum fields if it is configured as query param or path param (#1042)" This reverts commit 4b5eadb. * Revert "fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 (#1050)" This reverts commit e58bf9d. * Revert "fix(deps): update dependency org.yaml:snakeyaml to v1.33 (#1043)" This reverts commit d615305. * Revert "chore(deps): update dependency org.apache.maven.plugins:maven-shade-plugin to v3.4.0 (#1038)" This reverts commit ce93705. * Revert "fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 (#1039)" This reverts commit dba69f4. * Revert "fix(deps): update dependency org.yaml:snakeyaml to v1.32 (#1037)" This reverts commit e754a7c.

…aram or path param (#1042) Get numeric value for Enum fields if it is configured as query param or path param. Refactor HttpBinding to include Field info and use builder.

….6.21 (#1042) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.20` -> `1.6.21` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.21/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.21/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.21/compatibility-slim/1.6.20)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.21/confidence-slim/1.6.20)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-iam</summary> ### [`v1.6.21`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#1621-httpsgithubcomgoogleapisjava-iamcomparev1620v1621-2022-11-23) [Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.20...v1.6.21) ##### Dependencies - Update dependency com.google.cloud:google-iam-policy to v1.6.20 ([#554](https://togithub.com/googleapis/java-iam/issues/554)) ([940af38](https://togithub.com/googleapis/java-iam/commit/940af38f2b1e4ea7846d5fe2b174b5c6f8962a67)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

fix: Get numeric value for Enum fields if it is configured as query p…

6e6d822

…aram or path param. Refactor HttpBinding to use builder.

blakeli0 requested review from a team as code owners September 22, 2022 15:48

blakeli0 added 2 commits September 22, 2022 12:06

fix: Add test cases for HttpBinding

4965b6d

fix: Add license header

7badc19

blakeli0 requested review from vam-google, meltsufin, alicejli and diegomarquezp September 22, 2022 17:00

diegomarquezp approved these changes Sep 22, 2022

View reviewed changes

alicejli reviewed Sep 26, 2022

View reviewed changes

blakeli0 added 2 commits September 26, 2022 16:01

Update HttpBindings.java

89eb436

Update HttpBindingsTest.java

9473265

blakeli0 merged commit 0fdfa67 into main Oct 3, 2022

blakeli0 deleted the fix-numeric-enum branch October 3, 2022 16:10

release-please bot mentioned this pull request Oct 3, 2022

chore(main): release 2.10.1 #1036

Merged

emmileaf added a commit that referenced this pull request Nov 3, 2022

Revert "fix: Get numeric value for Enum fields if it is configured as…

740b117

… query param or path param (#1042)" This reverts commit 4b5eadb.

emmileaf added a commit that referenced this pull request Nov 3, 2022

Revert "fix: Get numeric value for Enum fields if it is configured as…

db69ce4

… query param or path param (#1042)" This reverts commit 4b5eadb.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Get numeric value for Enum fields if it is configured as query param or path param #1042

fix: Get numeric value for Enum fields if it is configured as query param or path param #1042

blakeli0 commented Sep 22, 2022 •

edited

Loading

alicejli left a comment

alicejli Sep 26, 2022

blakeli0 Sep 27, 2022

sonarqubecloud bot commented Sep 27, 2022

fix: Get numeric value for Enum fields if it is configured as query param or path param #1042

fix: Get numeric value for Enum fields if it is configured as query param or path param #1042

Conversation

blakeli0 commented Sep 22, 2022 • edited Loading

alicejli left a comment

Choose a reason for hiding this comment

alicejli Sep 26, 2022

Choose a reason for hiding this comment

blakeli0 Sep 27, 2022

Choose a reason for hiding this comment

sonarqubecloud bot commented Sep 27, 2022

blakeli0 commented Sep 22, 2022 •

edited

Loading