fix(ast): add import generation for annotations on VariableExpr #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmileaf
changed the title
blakeli0
reviewed
Oct 31, 2022
| AnnotationNode annotation = | ||
| AnnotationNode.builder() | ||
| .setType(fakeAnnotationType) | ||
| .setDescription( |
There was a problem hiding this comment.
Do we have to set descriptions? If not, removing it makes the test more concise.
There was a problem hiding this comment.
Ah true, not for the functionality this test intends to cover - replaced with Min's suggestion below!
zhumin8
reviewed
Oct 31, 2022
| VariableExpr.builder() | ||
| .setVariable(variable) | ||
| .setIsDecl(true) | ||
| .setAnnotations(Arrays.asList(annotation)) |
There was a problem hiding this comment.
Nit: extremely small point, might save just a few lines using the concrete Generated as test.
.setAnnotations(Arrays.asList(
AnnotationNode.withType(
TypeNode.withReference(ConcreteReference.withClazz(Generated.class)))))
There was a problem hiding this comment.
Ohh I hadn't realized this - thank you for the suggestion and updated!
|
Kudos, SonarCloud Quality Gate passed! |
zhumin8
approved these changes
Nov 1, 2022
emmileaf
added a commit
that referenced
this pull request
Nov 3, 2022
* This PR is a follow-up patch to #1012 which added support for annotations on VariableExpr. It updates ImportWriterVisitor so that import generation also covers these annotations.
emmileaf
added a commit
that referenced
this pull request
Nov 3, 2022
* Revert "test: update golden files after annotations import fix" This reverts commit 0bbfc59. * Revert "fix(ast): add import generation for annotations on VariableExpr (#1076)" This reverts commit 9e4721f. * Revert "chore(main): release 2.10.3 (#1079)" This reverts commit 63b9bce. * Revert "fix: fixes regionTag breakage (#1068)" This reverts commit cd35be8. * Revert "fix: fix REST transport client creation generated javadoc sample (#1077)" This reverts commit 5346eef. * Revert "refactor: expose parsed api short name and version as fields in Service (#1075)" This reverts commit 2ebe948. * Revert "chore(deps): update dependency org.apache.maven.plugins:maven-shade-plugin to v3.4.1 (#1072)" This reverts commit 6774245. * Revert "chore(main): release 2.10.2 (#1067)" This reverts commit e8ee82f. * Revert "fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 (#1063)" This reverts commit aa1782d. * Revert "fix: update regionTag to use service name (#1047)" This reverts commit 38010fd. * Revert "chore(main): release 2.10.1 (#1036)" This reverts commit 3282e0f. * Revert "deps: Upgrade protobuf to 3.21.7 (#1048)" This reverts commit c768691. * Revert "fix: update sample region tag to parse host instead of proto package (#1040)" This reverts commit eb94f30. * Revert "chore(deps): update dependency com.google.auto.value:auto-value to v1.10 (#1058)" This reverts commit bd5599f. * Revert "fix: Get numeric value for Enum fields if it is configured as query param or path param (#1042)" This reverts commit 4b5eadb. * Revert "fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 (#1050)" This reverts commit e58bf9d. * Revert "fix(deps): update dependency org.yaml:snakeyaml to v1.33 (#1043)" This reverts commit d615305. * Revert "chore(deps): update dependency org.apache.maven.plugins:maven-shade-plugin to v3.4.0 (#1038)" This reverts commit ce93705. * Revert "fix(deps): update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 (#1039)" This reverts commit dba69f4. * Revert "fix(deps): update dependency org.yaml:snakeyaml to v1.32 (#1037)" This reverts commit e754a7c.
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
* This PR is a follow-up patch to #1012 which added support for annotations on VariableExpr. It updates ImportWriterVisitor so that import generation also covers these annotations.
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ## [2.9.2](https://togithub.com/googleapis/java-core/compare/v2.9.1...v2.9.2) (2023-01-18) ### Dependencies * Update dependency io.grpc:grpc-bom to v1.52.1 ([#1073](https://togithub.com/googleapis/java-core/issues/1073)) ([1a64265](https://togithub.com/googleapis/java-core/commit/1a64265a99bdf685aebb6821de1fc43c9361feab)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up patch to #1012 which added support for annotations on
VariableExpr. It updatesImportWriterVisitorso that import generation also covers these annotations.Note: the Spring CodeGen branch (autoconfig-gen-draft2) will need a rebase after this is merged, and have its golden test files updated to reflect this change.