feat: add stream method for ServerStream
#1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeWang1127
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
LGTM |
suztomo
approved these changes
Mar 31, 2023
suztomo
added
the
do not merge
blakeli0
reviewed
Mar 31, 2023
| @@ -89,6 +91,10 @@ public Iterator<V> iterator() { | |||
| return iterator; | |||
| } | |||
|
|
|||
| public Stream<V> stream() { | |||
There was a problem hiding this comment.
Can you please add Javadoc? All public methods are required to have Javadoc.
blakeli0
reviewed
Mar 31, 2023
| @@ -89,6 +91,10 @@ public Iterator<V> iterator() { | |||
| return iterator; | |||
| } | |||
|
|
|||
| public Stream<V> stream() { | |||
| return StreamSupport.stream(this.spliterator(), false); | |||
There was a problem hiding this comment.
I see that the second argument is set to false, which means this is a sequential stream, do we want to expose another parallelStream method as well?
There was a problem hiding this comment.
I'm not sure whether a deterministic result is required as parallel stream can randomize the result.
Also, we could explore more about parallel stream later as we did in Page.
product-auto-label
bot
added
size: m
suztomo
removed
the
do not merge
blakeli0
approved these changes
Apr 11, 2023
|
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! |
|
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! |
|
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed! |
JoeWang1127
pushed a commit
that referenced
this pull request
Apr 11, 2023
…1575) (#914) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
JoeWang1127
pushed a commit
that referenced
this pull request
Apr 11, 2023
…1575) (#795) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1576 ☕️