Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google_java_format_verification is broken #914

Closed
chanseokoh opened this issue Jan 27, 2022 · 0 comments · Fixed by #915
Closed

google_java_format_verification is broken #914

chanseokoh opened this issue Jan 27, 2022 · 0 comments · Fixed by #915
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chanseokoh
Copy link
Contributor

I wonder if this ever worked.

$ bazel build :google_java_format_verification
...
ERROR: /home/chanseok/workspace/gapic-generator-java/BUILD.bazel:112:32: If this target fails check the list of files that must be formatted in bazel-out/k8-fastbuild/bin/google_java_format_verification.txt failed: (Exit 1): bash failed: error executing command /bin/bash -c 'bazel-out/host/bin/google_java_format_binary $@ > bazel-out/k8-fastbuild/bin/google_java_format_verification.txt' '' --dry-run --set-exit-if-changed ... (remaining 254 argument(s) skipped)
@chanseokoh chanseokoh added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 27, 2022
@chanseokoh chanseokoh mentioned this issue Jan 27, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 28, 2022
@chanseokoh
chore: re-work build infra, primarily around code format machinery (#915
99b3da7 
)

- Removes `gapic_generator_java.bzl`.

- `:google_java_format_verification` is now working. (Fixes #914.)

- `:google_java_format_verification` now runs with `bazel run` instead of `bazel build`, which is consistent with how `:google_java_format` runs.

- Removes manual listing of files to format, which is error-prone. This actually revealed that we were missing out some files for formatting. (For example, `AbstractTransportServiceStubClassComposer.java` had an unused import.) 

- Removes unnecessary `filegroup` definitions triggered by removing manual file listing.

- Reduces visibility of many packages.
suztomo pushed a commit that referenced this issue Dec 16, 2022
@chanseokoh
chore: re-work build infra, primarily around code format machinery (#915
ad59211 
)

- Removes `gapic_generator_java.bzl`.

- `:google_java_format_verification` is now working. (Fixes #914.)

- `:google_java_format_verification` now runs with `bazel run` instead of `bazel build`, which is consistent with how `:google_java_format` runs.

- Removes manual listing of files to format, which is error-prone. This actually revealed that we were missing out some files for formatting. (For example, `AbstractTransportServiceStubClassComposer.java` had an unused import.) 

- Removes unnecessary `filegroup` definitions triggered by removing manual file listing.

- Reduces visibility of many packages.
suztomo pushed a commit that referenced this issue Mar 21, 2023
@renovate-bot
deps: update dependency com.google.cloud.tools:dependencies to v1.5.13 (
f7585ac 
#914)
suztomo pushed a commit that referenced this issue Mar 21, 2023
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
014bafc 
…1575) (#914)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: re-work build infra, primarily around code format machinery googleapis/sdk-platform-java
1 participant
@chanseokoh