fix: add support for field with name 'self' (#2205)

googleapis · Oct 8, 2024 · ed88fe2 · ed88fe2
1 parent ab19c5a
commit ed88fe2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/gapic/utils/reserved_names.py b/gapic/utils/reserved_names.py
@@ -89,6 +89,8 @@
         "exec",
         "help",
         # Comes from Protoplus
-        "ignore_unknown_fields"
+        "ignore_unknown_fields",
+        "self",  # Refer to PEP8 https://peps.python.org/pep-0008/#function-and-method-arguments
+        "cls",  # Refer PEP8 https://peps.python.org/pep-0008/#function-and-method-arguments
     ]
 )
diff --git a/tests/fragments/test_reserved_field_name.proto b/tests/fragments/test_reserved_field_name.proto
@@ -34,6 +34,10 @@ message MethodRequest {
   string any = 4;
   string license = 5;
   string type = 6;
+  // Refer to PEP8 https://peps.python.org/pep-0008/#function-and-method-arguments
+  string self = 7;
+  // Refer to PEP8 https://peps.python.org/pep-0008/#function-and-method-arguments
+  string cls = 8;
 }
 
 message MethodResponse {