Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore 100% coverage in generated clients #1369

Closed
parthea opened this issue Jul 23, 2022 · 0 comments · Fixed by #1368
Closed

Restore 100% coverage in generated clients #1369

parthea opened this issue Jul 23, 2022 · 0 comments · Fixed by #1368
Assignees
@parthea
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Jul 23, 2022

In PR googleapis/python-network-security#115, the coverage check is failing. See the results below and the build log here: https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true

----------------------------------------------------------------------------------------------------------------------------------------
google/cloud/network_security_v1/__init__.py                                                     7      0      0      0   100%
google/cloud/network_security_v1/services/__init__.py                                            0      0      0      0   100%
google/cloud/network_security_v1/services/network_security/__init__.py                           3      0      0      0   100%
google/cloud/network_security_v1/services/network_security/async_client.py                     268      0     80      0   100%
google/cloud/network_security_v1/services/network_security/client.py                           385      0    150      0   100%
google/cloud/network_security_v1/services/network_security/pagers.py                           119      0     42      0   100%
google/cloud/network_security_v1/services/network_security/transports/__init__.py                9      0      0      0   100%
google/cloud/network_security_v1/services/network_security/transports/base.py                   95      0     [14](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:15)      0   100%
google/cloud/network_security_v1/services/network_security/transports/grpc.py                  135      0     48      0   100%
google/cloud/network_security_v1/services/network_security/transports/grpc_asyncio.py          134      0     48      0   100%
google/cloud/network_security_v1/types/__init__.py                                               6      0      0      0   100%
google/cloud/network_security_v1/types/authorization_policy.py                                  52      0     24      0   100%
google/cloud/network_security_v1/types/client_tls_policy.py                                     36      0     14      0   100%
google/cloud/network_security_v1/types/common.py                                                12      0      2      0   100%
google/cloud/network_security_v1/types/server_tls_policy.py                                     38      0     [16](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:17)      0   100%
google/cloud/network_security_v1/types/tls.py                                                   13      0      8      0   100%
google/cloud/network_security_v1beta1/__init__.py                                                7      0      0      0   100%
google/cloud/network_security_v1beta1/services/__init__.py                                       0      0      0      0   100%
google/cloud/network_security_v1beta1/services/network_security/__init__.py                      3      0      0      0   100%
google/cloud/network_security_v1beta1/services/network_security/async_client.py                333      0     98      0   100%
google/cloud/network_security_v1beta1/services/network_security/client.py                      450      0    168      0   100%
google/cloud/network_security_v1beta1/services/network_security/pagers.py                      119      0     42      0   100%
google/cloud/network_security_v1beta1/services/network_security/transports/__init__.py           9      0      0      0   100%
google/cloud/network_security_v1beta1/services/network_security/transports/base.py             125      0     14      0   100%
google/cloud/network_security_v1beta1/services/network_security/transports/grpc.py             [18](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:19)3      0     66      0   100%
google/cloud/network_security_v1beta1/services/network_security/transports/grpc_asyncio.py     182      0     66      0   100%
google/cloud/network_security_v1beta1/types/__init__.py                                          6      0      0      0   100%
google/cloud/network_security_v1beta1/types/authorization_policy.py                             52      0     24      0   100%
google/cloud/network_security_v1beta1/types/client_tls_policy.py                                36      0     14      0   100%
google/cloud/network_security_v1beta1/types/common.py                                           12      0      2      0   100%
google/cloud/network_security_v1beta1/types/server_tls_policy.py                                38      0     16      0   100%
google/cloud/network_security_v1beta1/types/tls.py                                              13      0      8      0   100%
tests/unit/__init__.py                                                                           0      0      0      0   100%
tests/unit/gapic/__init__.py                                                                     0      0      0      0   100%
tests/unit/gapic/network_security_v1/__init__.py                                                 0      0      0      0   100%
tests/unit/gapic/network_security_v1/test_network_security.py                                 [20](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:21)56      0    500      0   100%
tests/unit/gapic/network_security_v1beta1/__init__.py                                            0      0      0      0   100%
tests/unit/gapic/network_security_v1beta1/test_network_security.py                            [26](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:27)01     45    608      0    98%   5868-5888, 6007-60[27](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:28), 6146-6166, 6[29](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:30)1-6[31](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:32)1, 64[36](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:37)-6456
----------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                         75[37](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:38)     [45](https://github.com/googleapis/python-network-security/runs/7482551826?check_suite_focus=true#step:6:46)   2072      0    99%
Coverage failure: total of 99 is less than fail-under=100
@parthea parthea self-assigned this Jul 23, 2022
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 23, 2022
@parthea parthea mentioned this issue Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@parthea