Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add async suffix to tests to avoid duplication with sync functions #1368

Merged
merged 3 commits into from
Jul 27, 2022
Merged

test: add async suffix to tests to avoid duplication with sync functions #1368

merged 3 commits into from
Jul 27, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jul 23, 2022 •
edited
Loading

Fixes #1369

@parthea parthea requested review from a team as code owners July 23, 2022 18:30
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 23, 2022
vam-google
vam-google approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea merged commit 18aa66f into main Jul 27, 2022
@parthea parthea deleted the add-async-suffix-to-tests branch July 27, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vam-google vam-google vam-google approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore 100% coverage in generated clients
2 participants
@parthea @vam-google