-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel build is missing .coveragerc #437
Comments
Otherwise this file is excluded from generation. Partially addresses #437
Otherwise this file is excluded from generation. Partially addresses #437
any updates as we are out of slo |
Note that the synthtool-generated `.coveragerc` (see #224) does *not* include all changes needed for 100% coverage: see: - googleapis/gapic-generator-python#171 - googleapis/gapic-generator-python#437 Closes #92. Closes #195.
@software-dov @vam-google Friendly ping. We now use Bazel in almost all the Python repositories so this is more of a problem. When I last tested this the Maybe the gapic-generator-python/rules_python_gapic/py_gapic_pkg.bzl Lines 26 to 36 in f28b43d
|
@vam-google @software-dov , any updates on this? We are out of SLO on this. Also, it seems important to fix this as we started to build libraries using bazel. thanks! |
@vam-google, any updates on this? |
@hkdevandla Working on it |
Apparently the issue was in bazel's |
Fixed in #723. Closing. |
Bazel builds seem to not have a .coveragerc. This file has been around for a while so I don't think it's a version issue.
Contents of tar (just missing
.coveragerc
)Resolved in #550:
Unit test subdirs are also missing the__init__.py
. https://github.com/googleapis/gapic-generator-python/blob/master/gapic/templates/tests/unit/gapic/%25name_%25version/%25sub/__init__.pyCC @vam-google
The text was updated successfully, but these errors were encountered: