Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown fields returned from the server break REST transport #780

Closed
vam-google opened this issue Feb 16, 2021 · 0 comments
Closed

Unknown fields returned from the server break REST transport #780

vam-google opened this issue Feb 16, 2021 · 0 comments
Assignees
@vam-google
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vam-google
Copy link
Contributor

If a server returns an unknown field in its JSON representation, the REST GAPIC client (for example GCE) breaks the decerialization on the client side. An example of error:

google.protobuf.json_format.ParseError: Message type "google.cloud.compute.v1.Zone" has no field named "supportsPzs".
@vam-google vam-google self-assigned this Feb 16, 2021
@vam-google vam-google added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 16, 2021
@vam-google vam-google mentioned this issue Feb 16, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Feb 17, 2021
@vam-google
fix: ignore unknown fields returned from server for REST (#777)
a70b078 
Otherwise the client may throw an exception if the server is newer than the client (i.e. some of the returned messages have new fields).
A tracking bug: #780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vam-google vam-google

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vam-google