Supported dictionaries not reflected in type annotations

[PicardParis]

Issue

Some methods support dictionaries but this is not reflected in the type annotations.

Example

This working code triggers a "dict[str, str]" cannot be assigned to type "ClientOptions | None" warning:

import google.cloud.documentai_v1 as documentai

client_options = dict(api_endpoint="eu-documentai.googleapis.com")
client = documentai.DocumentProcessorServiceClient(client_options=client_options)

In the client library generated source code, dictionaries are supported:

if isinstance(client_options, dict):
    client_options = client_options_lib.from_dict(client_options)

but the typing is incomplete:

client_options: Optional[client_options_lib.ClientOptions] = None,

Note: This is just an example. There are multiple similar occurrences in different client libraries (if isinstance(xxx, dict) could be a marker to find them).

[software-dov]

Fixed in current generated surfaces.

[PicardParis]

Thanks for the fix!

[PicardParis]

• I retested the recent google-cloud-documentai==1.5.0 version and still see the issue:

  Argument of type "dict[str, str]" cannot be assigned to parameter "client_options" of type "ClientOptions | None" in function 
  "__init__"
    Type "dict[str, str]" cannot be assigned to type "ClientOptions | None"
      "dict[str, str]" is incompatible with "ClientOptions"
  

• If you check the source, client_options supports dictionaries yet its declaration does not:

      def __init__(
          self,
          *,
          credentials: Optional[ga_credentials.Credentials] = None,
          transport: Union[str, DocumentProcessorServiceTransport, None] = None,
          client_options: Optional[client_options_lib.ClientOptions] = None,
          client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO,
      ) -> None:
          if isinstance(client_options, dict):
              client_options = client_options_lib.from_dict(client_options)
  

• Expected: client_options: Union[client_options_lib.ClientOptions, dict, None] = None,
• Is the issue still present (reopen this issue?) or should client libraries be generated differently?