Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix docs build for numbered lists #1740

Merged
merged 13 commits into from
Sep 6, 2023
Merged

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 14, 2023

Fixes #1723 🦕
Fixes #1724 🦕

@parthea parthea requested a review from a team as a code owner August 14, 2023 15:05
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 14, 2023
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's make this robust to numbered list entries whose numbers are more than one digit.

gapic/utils/lines.py Outdated Show resolved Hide resolved
gapic/utils/lines.py Outdated Show resolved Hide resolved
tests/unit/utils/test_lines.py Show resolved Hide resolved
@parthea parthea assigned vchudnov-g and unassigned parthea Sep 2, 2023
@parthea parthea force-pushed the fix-docs-build-numbered-list branch from 7e54960 to 90747b2 Compare September 2, 2023 10:50
@parthea parthea deleted the fix-docs-build-numbered-list branch September 6, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
3 participants