Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Nov 8, 2025

@parthea parthea requested a review from a team as a code owner November 8, 2025 14:31
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 8, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates the transition of the repository's automated processes from the previous OwlBot and release-please systems to a new 'librarian' framework. This foundational change streamlines the automation setup by consolidating configurations into a single .librarian/state.yaml file, while also cleaning up obsolete configuration files. A minor enhancement to the CHANGELOG.md provides better historical context for releases.

Highlights

  • Librarian Onboarding: The repository is being onboarded to the 'librarian' system, which involves replacing existing automation configurations with a new .librarian/state.yaml file.
  • Removal of OwlBot and Release-Please Configurations: Several files related to OwlBot and release-please automation, including .github/.OwlBot.lock.yaml, .github/.OwlBot.yaml, .github/release-please.yml, .github/release-trigger.yml, and owlbot.py, have been removed.
  • Changelog Update: The CHANGELOG.md file has been updated to include a link to the PyPI history for gapic-generator.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully onboards the repository to Librarian, migrating it from the previous OwlBot setup. The changes primarily involve removing OwlBot-related configuration files and scripts, and introducing the new .librarian/state.yaml configuration. The modifications are clean and directly support the migration. I have one suggestion to improve the reproducibility of the generation process by pinning the Docker image in the new configuration.

@daniel-sanche
Copy link
Contributor

Let's make sure we get #2472 in before onboarding this

@parthea
Copy link
Contributor Author

parthea commented Nov 10, 2025

@daniel-sanche, I reached out offline. I don't believe #2472 is a blocker

Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions.

@@ -0,0 +1,10 @@
image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:4e3486fee9eba44b75a18c67f0c60fa0c4af675132305e3ff3fae2e9b94f94bb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often do we need to update this SHA? How do we know? When do we do it? Could document this somewhere? (Maybe in a top level README or maybe in a comment in this YAML)

Copy link
Contributor Author

@parthea parthea Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason to update the SHA is when there is a specific feature or fix which is only available in a newer image. This is similar to any dependency update. In this case, there is a specific fix that we needed from googleapis/google-cloud-python#14862

Use the instructions here to update the SHA: https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#pin-the-language-container-version-in-stateyaml

librarian update-image -image=us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620

@parthea parthea merged commit b58591d into main Nov 11, 2025
139 checks passed
@parthea parthea deleted the onboard-librarian branch November 11, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants