-
Notifications
You must be signed in to change notification settings - Fork 74
chore(librarian): onboard to librarian #2479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request initiates the transition of the repository's automated processes from the previous OwlBot and release-please systems to a new 'librarian' framework. This foundational change streamlines the automation setup by consolidating configurations into a single Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully onboards the repository to Librarian, migrating it from the previous OwlBot setup. The changes primarily involve removing OwlBot-related configuration files and scripts, and introducing the new .librarian/state.yaml configuration. The modifications are clean and directly support the migration. I have one suggestion to improve the reproducibility of the generation process by pinning the Docker image in the new configuration.
|
Let's make sure we get #2472 in before onboarding this |
|
@daniel-sanche, I reached out offline. I don't believe #2472 is a blocker |
vchudnov-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions.
| @@ -0,0 +1,10 @@ | |||
| image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:4e3486fee9eba44b75a18c67f0c60fa0c4af675132305e3ff3fae2e9b94f94bb | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How often do we need to update this SHA? How do we know? When do we do it? Could document this somewhere? (Maybe in a top level README or maybe in a comment in this YAML)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason to update the SHA is when there is a specific feature or fix which is only available in a newer image. This is similar to any dependency update. In this case, there is a specific fix that we needed from googleapis/google-cloud-python#14862
Use the instructions here to update the SHA: https://github.com/googleapis/librarian/blob/main/doc/language-onboarding.md#pin-the-language-container-version-in-stateyaml
librarian update-image -image=us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
Towards googleapis/librarian#2451