Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: distinguish default/mtls endpoint for tests #551

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Conversation

arithmetic1728
Copy link
Collaborator

@arithmetic1728 arithmetic1728 commented Jul 23, 2020

showcase has default endpoint localhost:7469, so mtls endpoint is the same. When we interchange client.DEFAULT_ENDPOINT and client.DEFAULT_MTLS_ENDPOINT by mistake, the unit tests still pass. This causes problem, because generated client lib always has *.googleapis.com as the default endpoint, so mtls endpoint is always different (*.mtls.googleapis.com), so client lib unit test always fail. This PR replaces the default endpoint in case it is localhost (as it does in showcase unit tests) so we can distinguish the endpoints in showcase unit test.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #551   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1477      1508   +31     
  Branches       308       308           
=========================================
+ Hits          1477      1508   +31     
Impacted Files Coverage Δ
gapic/schema/api.py 100.00% <0.00%> (ø)
gapic/schema/imp.py 100.00% <0.00%> (ø)
gapic/utils/cache.py 100.00% <0.00%> (ø)
gapic/schema/metadata.py 100.00% <0.00%> (ø)
gapic/schema/wrappers.py 100.00% <0.00%> (ø)
gapic/generator/options.py 100.00% <0.00%> (ø)
gapic/samplegen/samplegen.py 100.00% <0.00%> (ø)
gapic/samplegen_utils/types.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a7062...4a36e0e. Read the comment docs.

@arithmetic1728 arithmetic1728 merged commit d80e109 into master Jul 23, 2020
@arithmetic1728 arithmetic1728 deleted the sijun branch July 23, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants