Skip to content

fix: rename local var page in generated tests #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2020
Merged

fix: rename local var page in generated tests #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gapic/ads-templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,8 +522,8 @@ def test_{{ method.name|snake_case }}_pages():
RuntimeError,
)
pages = list(client.{{ method.name|snake_case }}(request={}).pages)
for page, token in zip(pages, ['abc','def','ghi', '']):
assert page.raw_page.next_page_token == token
for page_, token in zip(pages, ['abc','def','ghi', '']):
assert page_.raw_page.next_page_token == token
{% elif method.lro and "next_page_token" in method.lro.response_type.fields.keys() %}
def test_{{ method.name|snake_case }}_raw_page_lro():
response = {{ method.lro.response_type.ident }}()
Expand Down
12 changes: 6 additions & 6 deletions gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,8 +838,8 @@ def test_{{ method.name|snake_case }}_pages():
RuntimeError,
)
pages = list(client.{{ method.name|snake_case }}(request={}).pages)
for page, token in zip(pages, ['abc','def','ghi', '']):
assert page.raw_page.next_page_token == token
for page_, token in zip(pages, ['abc','def','ghi', '']):
assert page_.raw_page.next_page_token == token

@pytest.mark.asyncio
async def test_{{ method.name|snake_case }}_async_pager():
Expand Down Expand Up @@ -928,10 +928,10 @@ async def test_{{ method.name|snake_case }}_async_pages():
RuntimeError,
)
pages = []
async for page in (await client.{{ method.name|snake_case }}(request={})).pages:
pages.append(page)
for page, token in zip(pages, ['abc','def','ghi', '']):
assert page.raw_page.next_page_token == token
async for page_ in (await client.{{ method.name|snake_case }}(request={})).pages:
pages.append(page_)
for page_, token in zip(pages, ['abc','def','ghi', '']):
assert page_.raw_page.next_page_token == token
{% elif method.lro and "next_page_token" in method.lro.response_type.fields.keys() %}
def test_{{ method.name|snake_case }}_raw_page_lro():
response = {{ method.lro.response_type.ident }}()
Expand Down