Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor typo in ads template #664

Merged
merged 11 commits into from
Oct 16, 2020
Merged

fix: minor typo in ads template #664

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3240be4
fix: minor typo in ads template
software-dov Oct 15, 2020
eb21a03
fix: CI runs alternative template tests
software-dov Oct 15, 2020
0642001
Satiate style check
software-dov Oct 16, 2020
9a60abb
More style check
software-dov Oct 16, 2020
a50dc04
Fix for 3.6 dependency stuff
software-dov Oct 16, 2020
0b4a073
Fix for showcase_mtls
software-dov Oct 16, 2020
0b25732
Expose (sync) client transport property to async client
software-dov Oct 16, 2020
f51836c
Tweak
software-dov Oct 16, 2020
b351d43
Merge branch 'master' into ads-experiment
software-dov Oct 16, 2020
ecca08c
Don't depend on showcase-unit-alternative-templates-3.6
software-dov Oct 16, 2020
ac5d78d
Merge branch 'ads-experiment' of https://github.com/software-dov/gapi…
software-dov Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/transports/base.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ class {{ service.name }}Transport(metaclass=abc.ABCMeta):
credentials identify the application to the service; if none
are specified, the client will attempt to ascertain the
credentials from the environment.
client_info (google.api_core.gapic_v1.client_info.ClientInfo):
The client info used to send a user-agent string along with
API requests. If ``None``, then default info will be used.
Generally, you only need to set this if you're developing
client_info (google.api_core.gapic_v1.client_info.ClientInfo):
The client info used to send a user-agent string along with
API requests. If ``None``, then default info will be used.
Generally, you only need to set this if you're developing
your own client library.
"""
# Save the hostname. Default to port 443 (HTTPS) if none is specified.
Expand Down Expand Up @@ -89,7 +89,7 @@ class {{ service.name }}Transport(metaclass=abc.ABCMeta):
{% if method.retry.max_backoff %}maximum={{ method.retry.max_backoff }},{% endif %}
{% if method.retry.backoff_multiplier %}multiplier={{ method.retry.backoff_multiplier }},{% endif %}
predicate=retries.if_exception_type(
{%- for ex in method.retry.retryable_exceptions|sort(attribute='__name__) %}
{%- for ex in method.retry.retryable_exceptions|sort(attribute='__name__') %}
exceptions.{{ ex.__name__ }},
{%- endfor %}
),
Expand Down