-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Raise GoogleAPICallError on REST response errors #891
Conversation
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1697 +89
Branches 328 347 +19
=========================================
+ Hits 1608 1697 +89
Continue to review full report at Codecov.
|
491c67f
to
f61e890
Compare
I think google-api-core has some functionality for handling error messages. Could that be used instead? See the original feature request in #769 |
Oh, interesting. Thanks for the pointers! Made changes; PTAL. |
Also changed PR title and description to match. |
While testing against Showcase, I found that server errors resulted in a large exception stack dump that did not include the body of the erroring response. This PR shortens the stack dump and prints out the request body.
Fixes #769