Skip to content

Commit

Permalink
fix: update test template for dynamic routing header (#1058)
Browse files Browse the repository at this point in the history
  • Loading branch information
alicejli committed Nov 17, 2021
1 parent 4693ef8 commit 1f210d4
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 9 additions & 0 deletions baselines/routingtest/test/gapic_test_service_v1.ts.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ describe('v1.TestServiceClient', () => {
});
client.initialize();
const request = generateSampleMessage(new protos.google.routingtest.v1.FibonacciRequest());
const expectedHeaderRequestParams = "";
const expectedOptions = {
otherArgs: {
headers: {
Expand All @@ -148,6 +149,7 @@ describe('v1.TestServiceClient', () => {
});
client.initialize();
const request = generateSampleMessage(new protos.google.routingtest.v1.FibonacciRequest());
const expectedHeaderRequestParams = "";
const expectedOptions = {
otherArgs: {
headers: {
Expand Down Expand Up @@ -181,6 +183,7 @@ describe('v1.TestServiceClient', () => {
});
client.initialize();
const request = generateSampleMessage(new protos.google.routingtest.v1.FibonacciRequest());
const expectedHeaderRequestParams = "";
const expectedOptions = {
otherArgs: {
headers: {
Expand All @@ -204,6 +207,7 @@ describe('v1.TestServiceClient', () => {
});
client.initialize();
const request = generateSampleMessage(new protos.google.routingtest.v1.FibonacciRequest());
const expectedHeaderRequestParams = "";
const expectedOptions = {
otherArgs: {
headers: {
Expand All @@ -226,6 +230,7 @@ describe('v1.TestServiceClient', () => {
});
client.initialize();
const request = generateSampleMessage(new protos.google.routingtest.v1.FibonacciRequest());
const expectedHeaderRequestParams = "";
const expectedOptions = {
otherArgs: {
headers: {
Expand Down Expand Up @@ -259,6 +264,7 @@ describe('v1.TestServiceClient', () => {
});
client.initialize();
const request = generateSampleMessage(new protos.google.routingtest.v1.FibonacciRequest());
const expectedHeaderRequestParams = "";
const expectedOptions = {
otherArgs: {
headers: {
Expand All @@ -282,6 +288,7 @@ describe('v1.TestServiceClient', () => {
});
client.initialize();
const request = generateSampleMessage(new protos.google.routingtest.v1.FibonacciRequest());
const expectedHeaderRequestParams = "";
const expectedOptions = {
otherArgs: {
headers: {
Expand All @@ -304,6 +311,7 @@ describe('v1.TestServiceClient', () => {
});
client.initialize();
const request = generateSampleMessage(new protos.google.routingtest.v1.FibonacciRequest());
const expectedHeaderRequestParams = "";
const expectedOptions = {
otherArgs: {
headers: {
Expand Down Expand Up @@ -337,6 +345,7 @@ describe('v1.TestServiceClient', () => {
});
client.initialize();
const request = generateSampleMessage(new protos.google.routingtest.v1.FibonacciRequest());
const expectedHeaderRequestParams = "";
const expectedOptions = {
otherArgs: {
headers: {
Expand Down
2 changes: 1 addition & 1 deletion templates/typescript_gapic/_util.njk
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ request.{{ oneComment.paramName.toCamelCase() }}

{%- macro initRequestWithHeaderParam(method) -%}
const request = generateSampleMessage(new protos{{ method.inputInterface }}());
{%- if method.headerRequestParams.length > 0 %}
{%- if method.headerRequestParams.length > 0 or method.dynamicRoutingRequestParams.length > 0 %}
{%- set expectedRequestParamJoiner = joiner("&") -%}
{%- set expectedRequestParams = "" %}
{%- for requestParam in method.headerRequestParams %}
Expand Down

0 comments on commit 1f210d4

Please sign in to comment.